Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19753#discussion_r152173508
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/VectorIndexer.scala ---
    @@ -55,7 +55,7 @@ private[ml] trait VectorIndexerParams extends Params with 
HasInputCol with HasOu
       override val handleInvalid: Param[String] = new Param[String](this, 
"handleInvalid",
         "How to handle invalid data (unseen labels or NULL values). " +
         "Options are 'skip' (filter out rows with invalid data), 'error' 
(throw an error), " +
    -    "or 'keep' (put invalid data in a special additional bucket, at index 
numLabels).",
    +    "or 'keep' (put invalid data in a special additional bucket, at index 
numCategories).",
    --- End diff --
    
    Can `numCategories` be confused for users with a defined constant? How 
about more verbose one: `at index of the number of categories of the feature`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to