Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19778#discussion_r152186300
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -841,6 +825,26 @@ class CodegenContext {
}
}
+ def splitCodes(expressions: Seq[String]): Seq[String] = {
--- End diff --
nit: private. We also need to write a comment.
How about `buildCodeBlocks`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
