Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19779#discussion_r152335633
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
    @@ -841,6 +841,75 @@ class VersionsSuite extends SparkFunSuite with Logging 
{
           }
         }
     
    +    test(s"$version: SPARK-17920: Insert into/overwrite external avro 
table") {
    +      withTempDir { dir =>
    +        val path = dir.getAbsolutePath
    +        val schemaPath = s"""$path${File.separator}avroschemadir"""
    --- End diff --
    
    nit:
    ```
    val schemaFile = new File(dir, "avroDecimal.avsc")
    val writer = new PrintWriter(schemaFile)
    writer.println(avroSchema)
    writer.close()
    ...
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to