Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19468#discussion_r152448480
  
    --- Diff: 
resource-managers/kubernetes/core/src/test/resources/log4j.properties ---
    @@ -0,0 +1,31 @@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#    http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
    +
    +# Set everything to be logged to the file target/unit-tests.log
    +log4j.rootCategory=INFO, file
    +log4j.appender.file=org.apache.log4j.FileAppender
    +log4j.appender.file.append=true
    +log4j.appender.file.file=target/unit-tests.log
    +log4j.appender.file.layout=org.apache.log4j.PatternLayout
    +log4j.appender.file.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss.SSS} %t 
%p %c{1}: %m%n
    +
    +# Ignore messages below warning level from a few verbose libraries.
    +log4j.logger.com.sun.jersey=WARN
    +log4j.logger.org.apache.hadoop=WARN
    +log4j.logger.org.eclipse.jetty=WARN
    +log4j.logger.org.mortbay=WARN
    +log4j.logger.org.spark_project.jetty=WARN
    --- End diff --
    
    shall we also put these in `config/log4j.properties.template`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to