Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r152980151
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockId.scala ---
@@ -52,8 +52,9 @@ case class RDDBlockId(rddId: Int, splitIndex: Int)
extends BlockId {
// Format of the shuffle block ids (including data and index) should be
kept in sync with
//
org.apache.spark.network.shuffle.ExternalShuffleBlockResolver#getBlockData().
@DeveloperApi
-case class ShuffleBlockId(shuffleId: Int, mapId: Int, reduceId: Int)
extends BlockId {
- override def name: String = "shuffle_" + shuffleId + "_" + mapId + "_" +
reduceId
+case class ShuffleBlockId(shuffleId: Int, mapId: Int, reduceId: Int,
length: Int = 1)
+ extends BlockId {
+ override def name: String = "shuffle_" + shuffleId + "_" + mapId + "_" +
reduceId + "_" + length
--- End diff --
these are semi-public interfaces, can we create a new block id
`ContinuousShuffleBlockIds`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
