Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19518
The PR looks good.
Although it can solve the constant pool pressure, however, I have a
question. Does it mean every time a constant falling in short range is used in
codes, we increase 1 byte in bytecodes because sipush is followed by two byte
value. I'm afraid it may be negative to some cases like many short constants in
a java program.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
