Github user koeninger commented on the issue: https://github.com/apache/spark/pull/19789 Seems reasonable to me but you should probably ask zsxwing if it fits in with plans for the structured streaming kafka code. On Thu, Nov 23, 2017 at 10:23 PM, Hyukjin Kwon <notificati...@github.com> wrote: > *@HyukjinKwon* commented on this pull request. > > Does this look good to you @koeninger <https://github.com/koeninger>? > ------------------------------ > > In external/kafka-0-10/src/main/scala/org/apache/spark/ > streaming/kafka010/KafkaRDD.scala > <https://github.com/apache/spark/pull/19789#discussion_r152895550>: > > > @@ -211,8 +211,8 @@ private[spark] class KafkaRDD[K, V]( > var requestOffset = part.fromOffset > > def closeIfNeeded(): Unit = { > - if (!useConsumerCache && consumer != null) { > - consumer.close > + if (consumer != null) { > + consumer.close() > > I think this should be double spaced > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/19789#pullrequestreview-78827551>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAGAB7EEFdiDoEY3ov2wmiDWrnCZN4gqks5s5kTLgaJpZM4QklrV> > . >
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org