Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19823#discussion_r153135417
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
    @@ -341,6 +341,12 @@ case class LoadDataCommand(
           } else {
             val uri = new URI(path)
             if (uri.getScheme() != null && uri.getAuthority() != null) {
    +          val hadoopConf = sparkSession.sessionState.newHadoopConf()
    +          val srcPath = new Path(path)
    --- End diff --
    
    I think here `path` is an URI here otherwise `val uri = new URI(path)` 
should fail, and we return `uri`. So, I think we should check if the `uri` is 
valid.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to