Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19797#discussion_r153380713
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
---
@@ -845,4 +845,24 @@ class CastSuite extends SparkFunSuite with
ExpressionEvalHelper {
val outputOuter = Row.fromSeq((1 to N).map(_ => outputInner))
checkEvaluation(cast(Literal.create(inputOuter, fromOuter), toOuter),
outputOuter)
}
+
+ test("SPARK-22570: should not create a lot of instance variables") {
--- End diff --
Could you elaborate this thought?
Do you want to this new check in test cases? Or do you mean we will remove
these tests for global variables since we will have new check in another PR?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
