Github user gberger commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19792#discussion_r153579071
  
    --- Diff: python/pyspark/sql/types.py ---
    @@ -1108,19 +1109,23 @@ def _has_nulltype(dt):
             return isinstance(dt, NullType)
     
     
    -def _merge_type(a, b):
    +def _merge_type(a, b, path=''):
    --- End diff --
    
    Hi folks, 
    
    Great options proposed by @HyukjinKwon - though I did not comprehend what 
was the conclusion of the discussion with @ueshin :)
    
    Which format should we employ? And do you want me to use this format right 
now or is it something you'll fix later?
    
    Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to