Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19751#discussion_r153939785
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -727,8 +769,8 @@ private[spark] class AppStatusListener(
}
}
- private def update(entity: LiveEntity, now: Long): Unit = {
- entity.write(kvstore, now)
+ private def update(entity: LiveEntity, now: Long, last: Boolean =
false): Unit = {
--- End diff --
I prefer how the current version reads on the call site, e.g.:
update(exec, now, last = true)
Also, Spark generally avoids Java-beans-style prefixes in Scala code (like
"is" or "get").
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
