Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/19843#discussion_r153964786
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -233,7 +232,8 @@ class LinearRegressionSuite
assert(model2.intercept ~== interceptR relTol 1E-3)
assert(model2.coefficients ~= coefficientsR relTol 1E-3)
- model1.transform(datasetWithDenseFeature).select("features",
"prediction").collect().foreach {
+ testTransformer[(Double, Vector)](datasetWithDenseFeature,
Seq(model1),
+ "features", "prediction") {
--- End diff --
I really like this, I'm impressed by how little we need to change to
leverage existing tests and have them run in both streaming and in batch mode!!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
