Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19811#discussion_r154010888
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -168,6 +166,21 @@ class CodegenContext {
       val mutableStates: mutable.ArrayBuffer[(String, String, String)] =
         mutable.ArrayBuffer.empty[(String, String, String)]
     
    +  // An array keyed by the tuple of mutable states' types and 
initialization code, holds the
    +  // current max index of the array
    +  var mutableStateArrayIdx: mutable.Map[(String, String), Int] =
    --- End diff --
    
    From the below code, looks like this is keyed by `(javaType, arrayName)`, 
instead of `(javaType, initCode)`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to