Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/19811
I 100% agree with @cloud-fan. Moreover, SPARK-22226 addresses the
additional constant pool entries generated by adding many methods. Even though
using a for loop in general has advantages, it is bringing a lot of complexity
in. Thus I think here we can go for the easy (even though maybe suboptimal) way
and then we can eventually create a further PR to improve it later.
Moreover, now, maybe the same for loop approach might be used also in other
places, other than the constructor, even though it would be even harder. Thus I
see this as a further optimization we can deal with separately.
WDYT?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
