Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19852#discussion_r154122767
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -319,7 +319,7 @@ private[spark] abstract class BasePythonRunner[IN, OUT](
case e: Exception if env.isStopped =>
logDebug("Exception thrown after context is stopped", e)
- null.asInstanceOf[OUT] // exit silently
+ throw new SparkException("Spark session has been stopped", e)
--- End diff --
I checked the code there are two places there `env.isStopped` is used:
* PythonRunner will complete silently when env.isStopped = true
* When retry failed tasked and env.isStopped, Spark will ignore
RejectedExecutionException.
As far as java tasks go, during shutdown I don't think there are code that
make them exit silently.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
