Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19631#discussion_r154218236
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala 
---
    @@ -58,18 +58,14 @@ import org.apache.spark.util.{CallerContext, Utils}
     
     private[spark] class Client(
         val args: ClientArguments,
    -    val hadoopConf: Configuration,
         val sparkConf: SparkConf)
       extends Logging {
     
       import Client._
       import YarnSparkHadoopUtil._
     
    -  def this(clientArgs: ClientArguments, spConf: SparkConf) =
    -    this(clientArgs, SparkHadoopUtil.get.newConfiguration(spConf), spConf)
    -
       private val yarnClient = YarnClient.createYarnClient
    -  private val yarnConf = new YarnConfiguration(hadoopConf)
    +  private val hadoopConf = new 
YarnConfiguration(SparkHadoopUtil.newConfiguration(sparkConf))
    --- End diff --
    
    Both are effectively the same; I chose too keep the name used more often to 
minimize changes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to