Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/19865
  
    making a variable global need to be done manually(call `ctx.mutableState`), 
splitting the code into methods also need to be done manually(call 
`ctx.splitExpressions`). If we hit a problem here, it's probably due to misuse. 
Can we just check the codebase, find these invalid cases and fix them? We may 
probably add document to `ctx.splitExpression` that global variables should not 
be in the parameter.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to