Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19869#discussion_r154528386
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
 ---
    @@ -444,6 +444,7 @@ case class HashAggregateExec(
         val funcName = ctx.freshName("doAggregateWithKeysOutput")
         val keyTerm = ctx.freshName("keyTerm")
         val bufferTerm = ctx.freshName("bufferTerm")
    +    val numOutput = metricTerm(ctx, "numOutputRows")
    --- End diff --
    
    update the `numOutputRows`  in the result function instead of doing it for 
both fast hash map and regular hash map.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to