Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19871#discussion_r154563902
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/DDLSourceLoadSuite.scala
---
@@ -54,11 +55,17 @@ class DDLSourceLoadSuite extends DataSourceTest with
SharedSQLContext {
.load().schema == StructType(Seq(StructField("stringType",
StringType, nullable = false))))
}
- test("should fail to load ORC without Hive Support") {
- val e = intercept[AnalysisException] {
- spark.read.format("orc").load()
+ test("should fail to load ORC only if spark.sql.orc.enabled=false and
without Hive Support") {
--- End diff --
Ur, those tests cover different cases.
- In this test: `true` -> Use new OrcFileFormat, `false` -> Throw Exception
(the existing behavior)
- In that test: `true` -> Use new OrcFileFormat, `false` -> Use old
OrcFileFormat (the existing behavior).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
