Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r154571348
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
---
@@ -115,9 +120,35 @@ abstract class Expression extends TreeNode[Expression]
{
}
}
+ /**
+ * Returns the input variables to this expression.
+ */
+ private def findInputVars(ctx: CodegenContext, eval: ExprCode):
Seq[ExprInputVar] = {
+ if (ctx.currentVars != null) {
+ val boundRefs = this.collect {
+ case b @ BoundReference(ordinal, _, _) if ctx.currentVars(ordinal)
!= null => (ordinal, b)
--- End diff --
shall we add an assert here to guarantee that,
`ctx.currentVars(ordinal).code` is empty?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
