Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19861#discussion_r154694199
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/sources/v2/ConfigSupport.java ---
    @@ -0,0 +1,37 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.sources.v2;
    +
    +import org.apache.spark.annotation.InterfaceStability;
    +import org.apache.spark.sql.sources.v2.reader.DataSourceV2Reader;
    +
    +import java.util.List;
    +
    +/**
    + * A mix-in interface for {@link DataSourceV2}. Data sources can implement 
this interface to
    + * propagate session configs with chosen key-prefixes to the particular 
data source.
    + */
    +@InterfaceStability.Evolving
    +public interface ConfigSupport {
    +
    +    /**
    +     * Create a list of key-prefixes, all session configs that match at 
least one of the prefixes
    +     * will be propagated to the data source options.
    +     */
    +    List<String> getConfigPrefixes();
    --- End diff --
    
    we need to think about the current use cases and validate this API. E.g. 
CSV data source and JSON data source both accept an option 
`columnNameOfCorruptRecord`, or session config 
`spark.sql.columnNameOfCorruptRecord`. We get the following information:
    
    1. mostly session config maps to an existing option.
    2. session configs are always prefixed with `spark.sql`, we should not ask 
the data source to always specify it.
    3. do we really need to support more than one prefixes?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to