Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19717#discussion_r155303789
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
    @@ -388,6 +388,33 @@ class SparkSubmitSuite
         conf.get("spark.ui.enabled") should be ("false")
       }
     
    +  test("handles k8s cluster mode") {
    +    val clArgs = Seq(
    +      "--deploy-mode", "cluster",
    +      "--master", "k8s://host:port",
    +      "--executor-memory", "5g",
    +      "--class", "org.SomeClass",
    +      "--driver-memory", "4g",
    +      "--conf", "spark.kubernetes.namespace=spark",
    +      "--conf", "spark.kubernetes.driver.docker.image=bar",
    --- End diff --
    
    Should we also test the arg "--kubernetes-namespace"?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to