Github user henryr commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155358158 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -52,6 +62,23 @@ abstract class SparkFunSuite getTestResourceFile(file).getCanonicalPath } + private def saveThreadNames(): Unit = { --- End diff -- Suggest turning this into runningThreadNames(): Set[String], and then you can use this method both in beforeAll() and in printRemainingThreadNames() (line 70). And you can maybe put the whitelist logic here as well.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org