Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18853#discussion_r155365351 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -61,6 +60,18 @@ object TypeCoercion { WindowFrameCoercion :: Nil + def rules(conf: SQLConf): List[Rule[LogicalPlan]] = { + if (conf.isHiveTypeCoercionMode) { + commonTypeCoercionRules :+ + HiveInConversion :+ + HivePromoteStrings + } else { + commonTypeCoercionRules :+ + InConversion :+ + PromoteStrings --- End diff -- Rename them to `NativeInConversion` and `NativePromoteStrings `
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org