Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r155373535
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -34,12 +36,24 @@ abstract class SparkFunSuite
with Logging {
// scalastyle:on
+ val threadWhiteList = Set(
+ "rpc-client.*", "rpc-server.*", "shuffle-client.*", "shuffle-server.*",
--- End diff --
It would be nice to add comments explaining why the threads are
whitelisted. Without an explanation to the contrary, I don't think any of these
should be whitelisted.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
