Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/19525#discussion_r155414284 --- Diff: mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala --- @@ -476,6 +476,10 @@ class DenseMatrix @Since("2.0.0") ( @Since("2.0.0") object DenseMatrix { + @Since("2.3.0") + private[ml] def unapply(dm: DenseMatrix): Option[(Int, Int, Array[Double], Boolean)] = --- End diff -- I'm neutral on this issue. It's ok to let it private but should remove ```Since```. We can make it public later when there is clear requirement.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org