Github user smurakozi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19920#discussion_r155852268
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala ---
@@ -88,4 +90,8 @@ private[history] class HistoryPage(parent: HistoryServer)
extends WebUIPage("")
private def makePageLink(showIncomplete: Boolean): String = {
UIUtils.prependBaseUri("/?" + "showIncomplete=" + showIncomplete)
}
+
+ private def isApplicationCompleted(appInfo: ApplicationInfo): Boolean = {
--- End diff --
I've checked the status and the history packages and found no suitable
object.
As it is only one extra copy of a tiny method and it's in test code I don't
think it would worth the extra complexity of introducing a new object, so I
think it's best to leave it as it is.
If we use it more frequently we can extract into a util object.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
