Github user danielvdende commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19911#discussion_r155916550
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
    @@ -147,14 +157,6 @@ abstract class JdbcDialect extends Serializable {
         case arrayValue: Array[Any] => 
arrayValue.map(compileValue).mkString(", ")
         case _ => value
       }
    -
    -  /**
    -   * Return Some[true] iff `TRUNCATE TABLE` causes cascading default.
    -   * Some[true] : TRUNCATE TABLE causes cascading.
    -   * Some[false] : TRUNCATE TABLE does not cause cascading.
    -   * None: The behavior of TRUNCATE TABLE is unknown (default).
    -   */
    -  def isCascadingTruncateTable(): Option[Boolean] = None
    --- End diff --
    
    Although, custom third party dialects may want it. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to