Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/19926#discussion_r156459771
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -71,27 +68,29 @@ class StreamExecution(
import org.apache.spark.sql.streaming.StreamingQueryListener._
- private val pollingDelayMs =
sparkSession.sessionState.conf.streamingPollingDelay
+ protected val pollingDelayMs: Long =
sparkSession.sessionState.conf.streamingPollingDelay
- private val minBatchesToRetain =
sparkSession.sessionState.conf.minBatchesToRetain
+ protected val minBatchesToRetain: Int =
sparkSession.sessionState.conf.minBatchesToRetain
--- End diff --
since this is a base class for both microbatch and continuous processing,
is it right to put this variable here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
