Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19948#discussion_r156540742
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala 
---
    @@ -2172,4 +2172,21 @@ class SQLQuerySuite extends QueryTest with 
SQLTestUtils with TestHiveSingleton {
           }
         }
       }
    +
    +  test("SPARK-19809 NullPointerException on zero-size ORC file") {
    +    Seq("native", "hive").foreach { orcImpl =>
    +      withSQLConf(SQLConf.ORC_IMPLEMENTATION.key -> orcImpl) {
    +        withTempPath { dir =>
    +          withTable("spark_19809") {
    +            sql(s"CREATE TABLE spark_19809(a int) STORED AS ORC LOCATION 
'$dir'")
    +            Files.touch(new File(s"${dir.getCanonicalPath}", "zero.orc"))
    +
    +            withSQLConf(HiveUtils.CONVERT_METASTORE_ORC.key -> "true") { 
// default since 2.3.0
    +              checkAnswer(sql("SELECT * FROM spark_19809"), Seq.empty)
    --- End diff --
    
    It's done.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to