Github user hhbyyh commented on the issue:
https://github.com/apache/spark/pull/19599
Many thanks for the review @smurakozi and @attilapiros.
> The PR is not complete (did not convert all Param[String] instances to
StringParam consistently) so it should be marked as WIP.
StringParam is compatible with existing Param[String] so we don't need to
update all the Param[String] together. Usually I would wait for some time to
confirm the change will not bring any potential issue. After that, we can try
to apply it to a wider range.
And I really don't want to update all the instances of Param[String] before
we agree what's the best practice for some implementation details.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
