Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19751#discussion_r156706018
  
    --- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala ---
    @@ -40,8 +41,10 @@ private[spark] abstract class LiveEntity {
     
       var lastWriteTime = 0L
    --- End diff --
    
    minor: can the initial value be -1 instead?  doesn't matter right now, but 
often in tests we use a manual clock starting at time 0.  That would cause 
problems w/ this default.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to