Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/2795#discussion_r18861574
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -340,8 +340,8 @@ private[spark] object Utils extends Logging {
val targetFile = new File(targetDir, filename)
val uri = new URI(url)
val fileOverwrite = conf.getBoolean("spark.files.overwrite",
defaultValue = false)
- uri.getScheme match {
- case "http" | "https" | "ftp" =>
+ Option(uri.getScheme) match {
+ case Some("http") | Some("https") | Some("ftp") =>
--- End diff --
Sorry for being late on this, but I'd really rather not see things like
`case Some("http") | Some("https") | Some("ftp") =>`. Instead, I'd do this as:
```scala
Option(uri.getScheme).getOrElse("file") match {
case "http" | "https" | "ftp" => ...
case "file" => ...
case _ =>
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
