GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/19981

    [SPARK-22786][SQL] only use AppStatusPlugin in history server

    ## What changes were proposed in this pull request?
    
    In https://github.com/apache/spark/pull/19681 we introduced a new interface 
called `AppStatusPlugin`, to register listeners and set up the UI for both live 
and history UI.
    
    However I think it's an overkill for live UI. For example, we should not 
register `SQLListener` if users are not using SQL functions. Previously we 
register the `SQLListener` and set up SQL tab when `SparkSession` is firstly 
created, which indicates users are going to use SQL functions. But in #19681 , 
we register the SQL functions during `SparkContext` creation. The same thing 
should apply to streaming too.
    
    I think we should keep the previous behavior, and only use this new 
interface for history server.
    
    To reflect this change, I also rename the new interface to 
`SparkHistoryUIPlugin`
    
    ## How was this patch tested?
    
    existing tests

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark listener

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19981.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19981
    
----
commit ba38723826c36ce99a61fbd37bd779a90c44d0a4
Author: Wenchen Fan <wenc...@databricks.com>
Date:   2017-12-14T17:31:21Z

    only use AppStatusPlugin in history server

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to