Github user shijinkui commented on the pull request:
https://github.com/apache/spark/pull/2751#issuecomment-59157814
the Pool#checkSpeculatableTasks method named ambiguity.
TaskSetManager.checkSpeculatableTasks:Check for tasks to be speculated and
return true if there are any
it put the specula table task to Map: speculatableTasks
bad smell design
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
