GitHub user mgaido91 opened a pull request:

    https://github.com/apache/spark/pull/19993

    [SPARK-22799][ML] Bucketizer should throw exception if single- and 
multi-column params are both set

    ## What changes were proposed in this pull request?
    
    Currently there is a mixed situation when both single- and multi-column are 
supported. In some cases exceptions are thrown, in others only a warning log is 
emitted. In this discussion 
https://issues.apache.org/jira/browse/SPARK-8418?focusedCommentId=16275049&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16275049,
 the decision was to throw an exception.
    
    The PR throws an exception in `Bucketizer`, instead of logging a warning.
    
    ## How was this patch tested?
    
    modified UT


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgaido91/spark SPARK-22799

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19993.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19993
    
----
commit 8f3581cf780dabdbf27ffd7924edf8c344d69b30
Author: Marco Gaido <marcogaid...@gmail.com>
Date:   2017-12-15T18:11:18Z

    [SPARK-22799][ML] Bucketizer should throw exception if single- and 
multi-column params are both set

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to