Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19981#discussion_r157333324
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -82,6 +82,19 @@ private[sql] class SharedState(val sparkContext:
SparkContext) extends Logging {
*/
val cacheManager: CacheManager = new CacheManager
+ /**
+ * A status store to query SQL status/metrics of this Spark application,
based on SQL-specific
+ * [[org.apache.spark.scheduler.SparkListenerEvent]]s.
+ */
+ val statusStore: SQLAppStatusStore = {
--- End diff --
Sure, it's fine if you want to expose it. But I'm pointing out that it's
pretty weird to expose a class in a ".internal" package through the API. Those
are not documented nor go through mima checks, so there's absolutely zero
guarantees about them.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
