Github user falaki commented on a diff in the pull request:
https://github.com/apache/spark/pull/19959#discussion_r157351383
--- Diff: dev/lint-r.R ---
@@ -27,10 +27,11 @@ if (! library(SparkR, lib.loc = LOCAL_LIB_LOC,
logical.return = TRUE)) {
# Installs lintr from Github in a local directory.
# NOTE: The CRAN's version is too old to adapt to our rules.
if ("lintr" %in% row.names(installed.packages()) == FALSE) {
--- End diff --
I can see two possibilities. Unfortunately, I cannot get access to machines
to verify:
1. There is already an older version so `("lintr" %in%
row.names(installed.packages())` returns 'TRUE`
2. When installing `lintr` in a new directory some transient dependency
check behaves different and we end up rejecting existing `Rcpp` version.
Why do you think re-installing `Rcpp` in a non-system directory is an
issue? This is under `$SPARK_HOME` and will be wiped with every new test.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
