Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20007#discussion_r157482926
  
    --- Diff: dev/make-distribution.sh ---
    @@ -168,12 +168,18 @@ echo "Build flags: $@" >> "$DISTDIR/RELEASE"
     # Copy jars
     cp "$SPARK_HOME"/assembly/target/scala*/jars/* "$DISTDIR/jars/"
     
    -# Only create the yarn directory if the yarn artifacts were build.
    +# Only create the yarn directory if the yarn artifacts were built.
     if [ -f 
"$SPARK_HOME"/common/network-yarn/target/scala*/spark-*-yarn-shuffle.jar ]; then
       mkdir "$DISTDIR/yarn"
       cp 
"$SPARK_HOME"/common/network-yarn/target/scala*/spark-*-yarn-shuffle.jar 
"$DISTDIR/yarn"
     fi
     
    +# Only create and copy the dockerfiles directory if the kubernetes 
artifacts were built.
    +if [ -d "$SPARK_HOME"/resource-managers/kubernetes/core/target/ ]; then
    +  mkdir -p "$DISTDIR/kubernetes/"
    +  cp -a 
"$SPARK_HOME"/resource-managers/kubernetes/docker/src/main/dockerfiles 
"$DISTDIR/kubernetes/"
    --- End diff --
    
    According to `build-push-docker-images.sh` in #19946, seems like the 
directories for Dockerfile are under `dockerfiles` instead of 
`kubernetes/dockerfiles`. Will you update the file later?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to