Github user liyinan926 commented on the issue:

    https://github.com/apache/spark/pull/19954
  
    > @liyinan926 we might be able to make the review smaller, though this 
makes some of the code we contribute on each push unusable on its own.
    
    @mccheah I think the biggest thing that makes reviewing this PR challenging 
is the way the code is structured, not the amount of changes. This PR is 
actually both shorter and conceptually simpler than the first two big ones, 
IMO. Unless we do a thorough refactoring of the code, I personally don't think 
splitting into smaller ones will help much on reducing the confusion. Splitting 
also risks making half baked feature into 2.3, which I personally don't think 
is a good idea.   


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to