Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19954#discussion_r157893995
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
 ---
    @@ -45,6 +45,59 @@ private[spark] class KubernetesClusterManager extends 
ExternalClusterManager wit
           masterURL: String,
           scheduler: TaskScheduler): SchedulerBackend = {
         val sparkConf = sc.getConf
    +    val maybeInitContainerConfigMap = 
sparkConf.get(INIT_CONTAINER_CONFIG_MAP_NAME)
    --- End diff --
    
    Could you remove "maybe" from these variables? There are some specific 
cases where "maybe" can help, but this is not one of them.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to