Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20021#discussion_r157962547
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -930,6 +930,18 @@ class CodegenContext {
// inline execution if only one block
blocks.head
} else {
+ if (Utils.isTesting) {
--- End diff --
as you said, it _may_ lead, but likely it doesn't. Then I do think that the
best option is to assert it only in testing, where this might help finding
_potential_ bugs. In production it is an overkill to throw an exception for a
situation which most likely is not a problem IMHO.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
