Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20026#discussion_r157966811
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -208,7 +209,7 @@ private class EncryptedBlockData(
conf: SparkConf,
key: Array[Byte]) extends BlockData {
- override def toInputStream(): InputStream =
Channels.newInputStream(open())
+ override def toInputStream(): InputStream = new
NioBufferedFileInputStream(file)
--- End diff --
This should create a `CryptoInputStream` right? Why could we simply new a
`NioBufferedFileInputStream` instead? Am I missing something?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
