Github user foxish commented on the issue: https://github.com/apache/spark/pull/19954 > I don't think they are independent as architecturally they make sense together and represent a single concern: enabling use of remote dependencies through init-containers. Missing any one of the three makes the feature unusable. I would also argue that it won't necessarily make review easier as reviewers need to mentally connect them together to make sense of each change set. I agree with this. This is pretty much one cohesive unit and splitting it up is going to probably lead to more difficulty in understanding it. From your comments @vanzin, it seems we definitely do need a good refactor here, and the community can undertake that in Q1 2018. This approach and code has been functionally tested over the last 3 releases of our fork - and I'd be fairly confident about its efficacy - broad changes at this point seem riskier to me from a 2.3 release perspective given that we're still in the process of improving spark-k8s integration testing coverage against apache/spark. cc/ @mccheah
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org