Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20020#discussion_r158018917
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala
 ---
    @@ -57,4 +45,8 @@ trait DataWritingCommand extends RunnableCommand {
         val serializableHadoopConf = new SerializableConfiguration(hadoopConf)
         new BasicWriteJobStatsTracker(serializableHadoopConf, metrics)
       }
    +
    +  def run(sparkSession: SparkSession, children: Seq[SparkPlan]): Seq[Row] 
= {
    +    throw new NotImplementedError
    --- End diff --
    
    shall we force all sub-classes to implement it?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to