Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/19788#discussion_r158121392 --- Diff: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java --- @@ -165,13 +165,23 @@ public ManagedBuffer getBlockData( String execId, int shuffleId, int mapId, - int reduceId) { + int reduceId, + int length) { --- End diff -- Please rename the variable - `length` is incorrect (here and other places), please rename to make it clear : `numBlocks `perhaps ?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org