Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19954#discussion_r158167975
  
    --- Diff: 
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/submit/steps/initcontainer/InitContainerConfigOrchestratorSuite.scala
 ---
    @@ -0,0 +1,82 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.k8s.submit.steps.initcontainer
    +
    +import org.apache.spark.{SparkConf, SparkFunSuite}
    +import org.apache.spark.deploy.k8s.Config._
    +import org.apache.spark.deploy.k8s.Constants._
    +
    +class InitContainerConfigOrchestratorSuite extends SparkFunSuite {
    +
    +  private val DOCKER_IMAGE = "init-container"
    +  private val SPARK_JARS = Seq(
    +    "hdfs://localhost:9000/app/jars/jar1.jar", "file:///app/jars/jar2.jar")
    +  private val SPARK_FILES = Seq(
    +    "hdfs://localhost:9000/app/files/file1.txt", 
"file:///app/files/file2.txt")
    +  private val JARS_DOWNLOAD_PATH = "/var/data/jars"
    +  private val FILES_DOWNLOAD_PATH = "/var/data/files"
    +  private val DOCKER_IMAGE_PULL_POLICY: String = "IfNotPresent"
    +  private val CUSTOM_LABEL_KEY = "customLabel"
    +  private val CUSTOM_LABEL_VALUE = "customLabelValue"
    +  private val INIT_CONTAINER_CONFIG_MAP_NAME = "spark-init-config-map"
    +  private val INIT_CONTAINER_CONFIG_MAP_KEY = "spark-init-config-map-key"
    +  private val SECRET_FOO = "foo"
    +  private val SECRET_BAR = "bar"
    +  private val SECRET_MOUNT_PATH = "/etc/secrets/init-container"
    +
    +  test ("including basic configuration step") {
    --- End diff --
    
    no space before `(`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to