Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20043#discussion_r158329715
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -56,7 +56,36 @@ import org.apache.spark.util.{ParentClassLoader, Utils}
* @param value A term for a (possibly primitive) value of the result of
the evaluation. Not
* valid if `isNull` is set to `true`.
*/
-case class ExprCode(var code: String, var isNull: String, var value:
String)
+case class ExprCode(var code: String, var isNull: ExprValue, var value:
ExprValue)
+
+
+// An abstraction that represents the evaluation result of [[ExprCode]].
+abstract class ExprValue
--- End diff --
I think we should classify `ExprValue` by our needs, not by java
definitions. Thinking about the needs, we wanna know: 1) if this value is
accessible anywhere and we don't need to carry it via method parameters. 2) if
this value needs to be carried with parameters, do we need to generate a
parameter name or use this value directly?
So basically we can combine `LiteralValue` and `GlobalValue`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
