Github user danielvdende commented on a diff in the pull request:
https://github.com/apache/spark/pull/20057#discussion_r158555400
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -120,11 +121,12 @@ abstract class JdbcDialect extends Serializable {
* The SQL query that should be used to truncate a table. Dialects can
override this method to
* return a query that is suitable for a particular database. For
PostgreSQL, for instance,
* a different query is used to prevent "TRUNCATE" affecting other
tables.
- * @param table The name of the table.
+ * @param table The table to truncate
+ * @param cascade (OPTIONAL) Whether or not to cascade the truncation.
Default: false
* @return The SQL query to use for truncating a table
*/
@Since("2.3.0")
- def getTruncateQuery(table: String): String = {
+ def getTruncateQuery(table: String, cascade: Boolean = false): String = {
--- End diff --
That would force all dialects to implement this method though, which would
lead to unnecessary code duplication. Moreover, removing the default value here
would change the public API, as it would force others who have written custom
dialects to change calls to this method.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
