Github user MLnick commented on the issue: https://github.com/apache/spark/pull/19527 Agree on keeping the new OneHotEncoderEstimator as an alias for 3.0 On Fri, 1 Dec 2017 at 23:29, jkbradley <notificati...@github.com> wrote: > *@jkbradley* commented on this pull request. > ------------------------------ > > In mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoder.scala > <https://github.com/apache/spark/pull/19527#discussion_r154452715>: > > > @@ -41,8 +41,12 @@ import org.apache.spark.sql.types.{DoubleType, NumericType, StructType} > * The output vectors are sparse. > * > * @see `StringIndexer` for converting categorical values into category indices > + * @deprecated `OneHotEncoderEstimator` will be renamed `OneHotEncoder` and this `OneHotEncoder` > > Note for the future: For 3.0, it'd be nice to do what you're describing > here but also leave OneHotEncoderEstimator as a deprecated alias. That way, > user code won't break but will have deprecation warnings when upgrading to > 3.0. > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/19527#pullrequestreview-80626010>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA_SB0bdyHJzm96I5a_rZTSxvo1ya0nxks5s8G-jgaJpZM4P9Yvj> > . >
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org